Read the framework version list from the published manifest - #124
Merged
Conversation
The pinnable versions came only from db/data/framework_versions.yml, so every design system release needed a trmnlp release before a plugin could pin it. The design system now publishes that file in a public repo, so read it there once per run and keep the bundled copy as the fallback when the request fails or the response is not a version list. Also refreshes the bundled copy: latest moves from 3.1.1 to 3.2.0.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of pinnable
framework_version:values came only fromdb/data/framework_versions.ymlinside the gem, so a design system release needed a trmnlp release before anyone could pin it. That file is now published in the public design system repo, so trmnlp reads it from there.latestmoves from 3.1.1 to 3.2.0rake framework:syncnow reads the published manifest by default; pass a local checkout for the previous behaviour