Fix compiler warnings in NetworkingTools and OverlayDisplaySettingsView - #307
Closed
hossain-khan wants to merge 1 commit into
Closed
Fix compiler warnings in NetworkingTools and OverlayDisplaySettingsView#307hossain-khan wants to merge 1 commit into
hossain-khan wants to merge 1 commit into
Conversation
Collaborator
Author
|
Hmm! can't take it now, requires bit more through testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two compilation warnings:
1. INVISIBLE_REFERENCE compiler warning in NetworkingTools.kt
HttpFailure.tagswith internal visibility. Accessing it via@Suppress("INVISIBLE_MEMBER", "INVISIBLE_REFERENCE")prompted a Kotlin 2.x compiler warning about unspecified compiler behavior.tags, eliminating the warning cleanly.2. currentWindowAdaptiveInfo deprecation warning in OverlayDisplaySettingsView.kt
currentWindowAdaptiveInfo()was deprecated inandroidx.compose.material3.adaptive:1.3.0in favor of supporting Large and Extra-Large breakpoints.supportLargeAndXLargeWidth = trueand scoped deprecation suppression on the composable default argument.Verification
./gradlew formatKotlin./gradlew lintKotlin testDebugUnitTest(all tests pass)./gradlew compileDebugKotlin compileReleaseKotlin(both debug and release compile cleanly with zero warnings)