Fix NonObservableLocale lint error in refresh log screens - #300
Merged
Conversation
…pResponseDetailsBottomSheet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Android Lint
NonObservableLocalefailure inDisplayRefreshLogScreenandHttpResponseDetailsBottomSheet.Rationale & Solution
Calling
Locale.getDefault()directly inside@Composablefunctions reads system locale state in a non-observable way. If a user changes system locale settings at runtime, composables will not re-compose automatically.Rather than relying on array indexing like
locales[0], this PR uses Compose's idiomatic, type-safeandroidx.compose.ui.text.intl.Locale.current.platformLocaleAPI.Key Changes
DisplayRefreshLogScreen.kt: Updated date formatting to useComposeLocale.current.platformLocalewithremember(locale).HttpResponseDetailsBottomSheet.kt: Updated timestamp formatting to useComposeLocale.current.platformLocalewithremember(locale).import androidx.compose.ui.text.intl.Locale as ComposeLocaleimport alias at top of files instead of inline package paths.Verification
./gradlew lintDebug— BUILD SUCCESSFUL (0 lint errors)../gradlew formatKotlin— Passed../gradlew lintKotlin— Passed../gradlew testDebugUnitTest— Passed (216 tests passed)../gradlew assembleDebug— BUILD SUCCESSFUL.