Skip to content

fix: release please chart sync#217

Merged
jaronoff97 merged 2 commits into
masterfrom
fix-release-please-chart-sync
Jul 6, 2026
Merged

fix: release please chart sync#217
jaronoff97 merged 2 commits into
masterfrom
fix-release-please-chart-sync

Conversation

@jaronoff97

Copy link
Copy Markdown
Contributor

No description provided.

@jaronoff97 jaronoff97 enabled auto-merge (squash) July 6, 2026 20:00
@jaronoff97 jaronoff97 merged commit e2f9f64 into master Jul 6, 2026
5 checks passed
@jaronoff97 jaronoff97 deleted the fix-release-please-chart-sync branch July 6, 2026 20:01
@tero-internal-bot tero-internal-bot Bot mentioned this pull request Jul 6, 2026
repository: ghcr.io/usetero/edge
pullPolicy: IfNotPresent
tag: ""
tag: "@sha256:c8e2fe40b23845012c6a6c9ca4b0865f0ea8da8599f8b9bdd15b60c48cab6f24"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical tero-edge/values.yaml:7

Setting image.tag to "@sha256:..." causes the rendered image reference to include a stray colon: ghcr.io/usetero/edge:@sha256:.... The template formats the image as {{ .Values.image.repository }}:{{ .Values.image.tag }}, so the @ prefix in the tag produces :@ instead of the valid digest separator @. Kubernetes rejects :@ in image references, so installs using the chart defaults fail to pull the tero-edge container. Set image.tag to "sha256:..." (without the leading @) so the template renders ghcr.io/usetero/edge:sha256:..., or update the template to handle digest references correctly.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @charts/tero-edge/values.yaml around line 7:

Setting `image.tag` to `"@sha256:..."` causes the rendered image reference to include a stray colon: `ghcr.io/usetero/edge:@sha256:...`. The template formats the image as `{{ .Values.image.repository }}:{{ .Values.image.tag }}`, so the `@` prefix in the tag produces `:@` instead of the valid digest separator `@`. Kubernetes rejects `:@` in image references, so installs using the chart defaults fail to pull the `tero-edge` container. Set `image.tag` to `"sha256:..."` (without the leading `@`) so the template renders `ghcr.io/usetero/edge:sha256:...`, or update the template to handle digest references correctly.

@macroscopeapp

macroscopeapp Bot commented Jul 6, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

1 blocking correctness issue found. An unresolved review comment identifies a critical bug: the image.tag value '@sha256:...' produces invalid Kubernetes image references that will fail to pull. This substantive issue warrants human review.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants