Open
Conversation
this PR is AI generated, isn't it (were you really too lazy to even write the text, and let the bot hallucinate it?) |
Author
|
Not lazy, just worried about making mistakes or missing the proper PR guidelines. I’m new to open source, so I feel like it has to be perfect. @sirlan-ff00ff |
Author
|
remove stale @memoclaw review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎨 Add color coding for memos based on tags
Description
This PR implements visual tag-based color coding for memos, addressing the feature request in [issue #5676]. Users can now visually distinguish memos by assigning colors to specific tags, similar to the color-coding functionality available in Google Keep.
Problem Statement
As mentioned in the original feature request, users migrating from Google Keep miss the ability to visually sort and identify notes by color. This visual organization helps users quickly spot specific types of notes (e.g., todos, urgent items) when scrolling through their memos.
Solution
Implemented a tag-based color system that:
Technical Implementation
New Files
web/src/utils/tag-colors.ts- Core utility module containing:TAG_COLORSconfiguration object for tag-to-color mappingsgetTagColorClasses()- Returns Tailwind classes based on memo tagshasColoredTag()- Helper to check if a memo has any colored tagsgetPrimaryColoredTag()- Returns the first colored tag from a memoModified Files
web/src/components/MemoView.tsx- Integrated the color utility to apply styling to memo cardsUsage
The system automatically detects tags on memos and applies the corresponding color. For example:
#todowill have a purple-tinted background with a purple left border#urgentwill have a red-tinted background with a red left borderDesign Decisions
Future Enhancements
Potential improvements for future PRs:
Testing
Related Issues
Closes #5676