chore: decompose finding SEC-24 into atomic implementation subtask - #237
Open
esafwan wants to merge 2 commits into
Open
chore: decompose finding SEC-24 into atomic implementation subtask#237esafwan wants to merge 2 commits into
esafwan wants to merge 2 commits into
Conversation
esafwan
changed the title
esafwan
changed the title
- Removed `allow_guest=True` from `get_site_name` in `ury_kot_display.py` so the endpoint is accessible only to authenticated users. - Updated `fetchAndSetSiteName` in `kot.vue` to include session credentials with API requests. - Added HTTP error handling to gracefully handle 403 Forbidden responses for unauthenticated requests and allow the native Frappe authentication flow to complete before retrying.
ShahalaKP-Tridz
marked this pull request as ready for review
July 28, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does / Summary
Decomposes security finding SEC-24 into an actionable, structured implementation subtask by generating
plans/SweepSecurity:SEC-24-plan.json.What it solves / Motivation
get_site_nameKOT display API endpoint inury/ury/api/ury_kot_display.py.URYMosaicremain functional after removing guest permissions.Key Technical Changes
plans/SweepSecurity:SEC-24-plan.jsonspecifying:allow_guest=Truefromget_site_namewhile keeping it whitelisted for authenticated users.ury/ury/api/ury_kot_display.pyandURYMosaic/src/components/kot.vue.impl, difficulty 1, risk 1, uncertainty 1, priority 100.