Skip to content

Conversation

@natamaki
Copy link

@natamaki natamaki commented Feb 7, 2016

No description provided.

@mokhov
Copy link

mokhov commented Feb 11, 2016

А где filterEqual?

@natamaki
Copy link
Author

добавила filterEqual

@mokhov
Copy link

mokhov commented Feb 11, 2016

select не должен выбирать по неизвестным значениям

lego.js Outdated
var collection = arguments[0];

for (var i = 1; i < arguments.length; i++) {
collection = arguments[i](collection);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Здесь можно использовать reduce

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Попробовала reduce, получилось более громоздко, чем в текущей реализации.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Покажи

@natamaki
Copy link
Author

правки внесены

lego.js Outdated
module.exports.query = function (collection /* операторы через запятую */) {
module.exports.query = function () {
var args = [].slice.call(arguments);
var collection = args[0];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var collection = args.shift();

следующую строчку можно удалить

@natamaki
Copy link
Author

@mokhov 🆙 правки внесены

@mokhov mokhov self-assigned this Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants