Add .ready promise to Subscriber #1372
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: Most commands return a promise that resolves when the command is complete/executed and its result can be relied upon, however
.subscribeand.psubscribereturnSubscriberinstances before theSUBSCRIBEcommands have completed their round trip to Redis, so it’s hard to know when the subscription(s) are ready, connected, and listening. This problem can be seen in the tests, which used a 500ms delay to try to ensure that the subscription was ready before sendingPUBLISHcommandsAs an alternative, this PR adds a
.readyproperty toSubscriberwhich clients canawaitto know when the subscription(s) are ready, i.e. when it’s safe to startpublishing commands..readyis the best name for this promise