DX-1485: Multi tabs and search history #17
Merged
+1,021
−391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
reviewed
May 22, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
Adds multi-tab support and search history enhancements, along with various style and hook updates across the data browser.
- Introduce a
useTabcontext and new tab UI (DatabrowserTabs) for per-tab state isolation - Enhance
SearchInputwith history tracking, deduplication, and keyboard navigation in a popover - Update multiple components to use
useTab, adjust styling/padding, and gate effects based on active tab
Reviewed Changes
Copilot reviewed 20 out of 57 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/databrowser/components/sidebar/skeleton-buttons.tsx | Adjust loading skeleton wrapper styles |
| src/components/databrowser/components/sidebar/search-input.tsx | Add search history, dedupe logic, popover with keyboard nav |
| src/components/databrowser/components/sidebar/keys-list.tsx | Switch key list to useTab store context |
| src/components/databrowser/components/sidebar/infinite-scroll.tsx | Guard fetch-on-mount by active tab, spread props & styles |
| src/components/databrowser/components/sidebar/index.tsx | Sidebar layout padding and removed borders/bg |
| src/components/databrowser/components/sidebar/empty.tsx | Empty state background styling |
| src/components/databrowser/components/sidebar/db-size.tsx | Swap to useRedis hook for DB-size query |
| src/components/databrowser/components/display/key-actions.tsx | Add “Copy key” menu item, update delete styling |
| src/components/databrowser/components/display/input/custom-editor.tsx | Gate Monaco language reset by active tab |
| src/components/databrowser/components/display/index.tsx | Remove border/bg and switch to useTab for key selection |
| src/components/databrowser/components/display/header-badges.tsx | Rename TTL hook import |
| src/components/databrowser/components/display/display-simple.tsx | Remove extra padding |
| src/components/databrowser/components/display/display-list.tsx | Switch list display to useTab, add transition-colors |
| src/components/databrowser/components/display/display-list-edit.tsx | Switch edit form to useTab, remove extra padding |
| src/components/databrowser/components/display/display-header.tsx | Switch header to useTab, remove padding |
| src/components/databrowser/components/databrowser-tabs.tsx | New tabs UI component |
| src/components/databrowser/components/databrowser-instance.tsx | New instance layout with panels (needs tab context) |
| src/components/databrowser/components/add-key-modal.tsx | Switch add-key modal to useTab |
| package.json | Bump Radix UI packages, add label package |
| index.html | Update playground script path |
CahidArda
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.