Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the main body of the Volunteer Table, which resolves the volunteer table issue. Currently, it is a draft as the
getVolunteersTableAPI (#82) that this PR depends on has not yet been merged.Screenshots
Initial State (using mock data)
Selecting Cells
Loading State
Empty State
Description / Notes
ag-gridlibrary, I have switched toreact-table, or Tanstack Table, to implement the functionalityreact-tablelibrarytailwindinstallation in the project for the visuals of the tablelucide-reactlibrary for the icons in the table columns and the search bar + filter + sorting componentsQuestions and Comments
Currently, this ticket depends on the
getVolunteersTableAPI (Implemented getVolunteersTable API function #80 #82), which is why it is a draftThe issue states:
However, neither the Figma nor
Volunteerreturn type fromgetVolunteersTableAPI contain the columnfuture_interest, and the API response also doesn't containprior_roleseither; I currently have them added since they are in the issue description, although I'm not sure if that's intentionalThe filter is temporarily implemented as a dropdown that allows the user to select the source of their data: from the backend API, temporary mock data, or no data, in order to demonstrate the functionality of the table
The is a temporary page in the
/volunteersendpoint to view the table, which presumably will be implemented properly later on; for now, it's here so anyone reviewing the PR can view the table easilyThe original application used Geiss as the main font, which I have changed to match the Figma and the TRCC design that uses Manrope, but let me know if setting it as Geiss was intentional
I have mostly matched the design of the Figma, including the colour of the search bar and filter/sort buttons, but let me know if I should change it to match it exactly
In the Figma dashboard update section, there are two different colours for the "Spring" cohort - I have opted to keep the spring colours the same across multiple years for clarity but let me know if this should be changed, and if so, how the colours of the cohorts are decided
