implement filter-general function by janiceelamm · Pull Request #44 · uoftblueprint/trcc

janiceelamm · 2025-11-21T19:39:12Z

implement this function that filters volunteers by general information (e.g. email, phone, position,etc.)

Basic testing
test case 1: AND with one unique value (op = "AND", column = "email", values = "v1@mail.com")

test case 2: AND with two values. (op = "AND", column = "pronouns", values = "He/him", "She/her")

Should return empty rows since this is filtering one column only.

test case 3: OR with two values ((op = "AND", column = "pronouns", values = "He/him", "She/her")

test case 4: Invalid op ((op = "hello", column = "email", values = "v1@mail.com")

vercel · 2025-11-21T19:39:19Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
trcc	Ignored	Preview	Feb 20, 2026 3:49am

Copilot

Pull request overview

This PR implements a new filtering API endpoint that allows querying the Volunteers table with AND/OR operations on specific columns. The implementation includes both the core filtering logic and an HTTP route handler to expose this functionality.

Adds a filter_general function with column validation and support for AND/OR operations
Creates a GET endpoint at /api/filter-general to expose the filtering functionality
Implements validation for parameters and returns appropriate error responses

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
src/lib/api/filter_general.ts	Core filtering logic with column whitelisting, AND/OR operation support, and Supabase query execution
src/app/api/filter-general/route.ts	HTTP route handler that validates query parameters and calls the filter_general function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-21T19:42:07Z

src/lib/api/filter_general.ts

+
+  const client = await createClient();
+
+  if (values.length == 0) {


Use strict equality operator (===) instead of loose equality (==) to avoid type coercion issues.

Suggested change

if (values.length == 0) {

if (values.length === 0) {

Copilot · 2025-11-21T19:42:07Z

src/lib/api/filter_general.ts

+    return { data: null, error: "No values provided." };
+  }
+
+  if (op == "AND") {


Use strict equality operator (===) instead of loose equality (==) to avoid type coercion issues.

Copilot · 2025-11-21T19:42:07Z

src/lib/api/filter_general.ts

+    const result = await client.from("Volunteers").select().eq(column, value);
+    return result;
+  }
+  if (op == "OR") {


Use strict equality operator (===) instead of loose equality (==) to avoid type coercion issues.

Suggested change

if (op == "OR") {

if (op === "OR") {

Copilot · 2025-11-21T19:42:07Z

src/lib/api/filter_general.ts

+  if (values.length == 0) {
+    return { data: null, error: "No values provided." };
+  }


The values.length check at line 24 is redundant since the route handler already validates this condition at line 10. This duplicate validation should be removed or the route handler's check should be removed to avoid redundancy.

Suggested change

if (values.length == 0) {

return { data: null, error: "No values provided." };

}

Copilot · 2025-11-21T19:42:08Z

src/lib/api/filter_general.ts

+export async function filter_general(
+  op: string,
+  column: string,
+  values: string[]
+) {


Missing JSDoc documentation for this public API function. Should include descriptions of parameters (op, column, values), the return type, and examples of valid operations. See getExample.ts comments for reference style.

Copilot · 2025-11-21T19:42:08Z

src/lib/api/filter_general.ts

+import { createClient } from "../client/supabase/server";
+
+export async function filter_general(
+  op: string,


The 'op' parameter allows any string value but only 'AND' and 'OR' are valid. Consider using a union type (op: 'AND' | 'OR') to enforce valid values at compile time and improve type safety.

Suggested change

op: string,

op: 'AND' | 'OR',

Copilot · 2025-11-21T19:42:08Z

src/app/api/filter-general/route.ts

+  const column = searchParams.get("column");
+  const values = searchParams.getAll("values");
+
+  if (!op || !column || values.length == 0) {


Use strict equality operator (===) instead of loose equality (==) to avoid type coercion issues.

Suggested change

if (!op || !column || values.length == 0) {

if (!op || !column || values.length === 0) {

ch-iv

We should generally aim to have written tests for every PR. Could you write some tests for the changes you've made?

ch-iv · 2025-11-22T01:44:57Z

src/app/api/filter-general/route.ts

I think the name of the directory filter-general is too generic. We want to convey more information about what this route does by giving it a more descriptive name.

ch-iv · 2025-11-22T01:45:46Z

src/app/api/filter-general/route.ts

We don't need to implement the route.

ch-iv · 2025-11-22T01:46:57Z

src/lib/api/filter_general.ts

@@ -0,0 +1,45 @@
+import { createClient } from "../client/supabase/server";
+
+export async function filter_general(


Similar comment to route naming. This function should be given a more descriptive name. The current name doesn't communicate what this method does.

ch-iv · 2025-11-22T01:47:18Z

src/lib/api/filter_general.ts

+  op: string,
+  column: string,
+  values: string[]
+) {


The return value of this function should be typed.

ch-iv · 2025-11-22T01:50:07Z

src/lib/api/filter_general.ts

+import { createClient } from "../client/supabase/server";
+
+export async function filter_general(
+  op: string,


(nit) Not a big fan of the name op. Something like matchType is more descriptive.

ch-iv · 2025-11-22T01:55:49Z

src/lib/api/filter_general.ts

+import { createClient } from "../client/supabase/server";
+
+export async function filter_general(
+  op: string,


We should rely on the TypeScript type system to enforce the validity of the value of op (as well as for other arguments.)

I suggest you created either an Enum or a literal value type for op.

type MatchType = "any" | "all";

then you can type the function argument as follows:

function filter_general(op: MatchType, ...)

and the ts compiler will let you know if the function contract is being violated when you pass in the wrong values for op.

ch-iv · 2025-11-22T01:56:13Z

src/lib/api/filter_general.ts

+
+export async function filter_general(
+  op: string,
+  column: string,


Same comment as for OP. This should be a type or an enum.

ch-iv · 2025-11-22T01:57:08Z

src/lib/api/filter_general.ts

+  const valid_columns = [
+    "name_org",
+    "pseudonym",
+    "pronouns",
+    "email",
+    "phone",
+    "position",
+    "opt_in_communication",
+  ];


We should get rid of this in favor of introducing a type or an enum for valid columns in a centralized helper in this codebase.

src/lib/api/getVolunteerByGeneralInfo.ts

notjackl3 · 2026-01-26T21:42:08Z

tests/lib/api/getVolunteerByGeneralInfo.test.ts

+      "She/her",
+    ]);
+    expect(result).toEqual({ data: mockData, error: null });
+  });


Great work so far, one final test you should have is when the input operator is invalid (not AND/OR)

notjackl3 · 2026-01-26T21:42:57Z

tests/lib/database/getVolunteerByGeneralInfo.integration.test.ts

@@ -0,0 +1,64 @@
+import { describe, it, expect, beforeEach, afterEach } from "vitest";


You should combine unit tests and integration tests into one file, within tests/lib/api!

notjackl3 · 2026-01-26T21:47:21Z

tests/lib/database/getVolunteerByGeneralInfo.integration.test.ts

+
+    const volunteer = result.data[0]!;
+    expect(volunteer.email).toBe("a@test.com");
+  });


You should add a test for AND operation on unique values. For example, email is unique, test what if you do AND operation on 2 emails

notjackl3 · 2026-01-26T21:47:57Z

src/lib/api/getVolunteerByGeneralInfo.ts

+
+type VolunteerRow = Database["public"]["Tables"]["Volunteers"]["Row"];
+
+export async function filter_by_general_info(


The function name should match the file name: getVolunteerByGeneralInfo!

notjackl3

LGTM!

Everything is fixed!

ch-iv · 2026-01-27T17:18:45Z

tests/lib/api/getVolunteerByGeneralInfo.test.ts

+type MockSupabaseClient = {
+  from: ReturnType<typeof vi.fn>;
+  select: ReturnType<typeof vi.fn>;
+  eq: ReturnType<typeof vi.fn>;
+  in: ReturnType<typeof vi.fn>;
+};


Why are we mocking?

notjackl3

LGTM!

ch-iv

lgtm

Resolved comments from PR completed unit tests fixing vercel issue fixing vercel issue1 fixing vercel issue3 fixing vercel issue3 fixing vercel issue2 fixing vercel issue resolving integration test fixed the test resolved comments Implement filter-general function changed to real database cleaned up mock tests

Copilot AI review requested due to automatic review settings November 21, 2025 19:39

Copilot started reviewing on behalf of janiceelamm November 21, 2025 19:39 View session

vercel bot deployed to Preview November 21, 2025 19:39 View deployment

Copilot finished reviewing on behalf of janiceelamm November 21, 2025 19:41

Copilot AI reviewed Nov 21, 2025

View reviewed changes

ch-iv previously requested changes Nov 22, 2025

View reviewed changes

vercel bot had a problem deploying to Preview January 16, 2026 19:34 Failure

vercel bot had a problem deploying to Preview January 17, 2026 18:31 Failure

vercel bot had a problem deploying to Preview January 17, 2026 19:52 Failure

vercel bot had a problem deploying to Preview January 17, 2026 20:13 Failure

vercel bot had a problem deploying to Preview January 18, 2026 07:35 Failure

vercel bot had a problem deploying to Preview January 19, 2026 03:03 Failure

vercel bot had a problem deploying to Preview January 19, 2026 03:25 Failure

vercel bot deployed to Preview January 19, 2026 04:48 View deployment

notjackl3 reviewed Jan 26, 2026

View reviewed changes

notjackl3 approved these changes Jan 27, 2026

View reviewed changes

ch-iv force-pushed the backend/filter-general-api branch from 66b64db to 902fc39 Compare January 27, 2026 17:14

ch-iv requested changes Jan 27, 2026

View reviewed changes

notjackl3 approved these changes Feb 20, 2026

View reviewed changes

ch-iv approved these changes Feb 20, 2026

View reviewed changes

notjackl3 force-pushed the backend/filter-general-api branch from 708d7f4 to 3dd964e Compare February 20, 2026 03:49

notjackl3 merged commit d0addac into main Feb 20, 2026
3 checks passed


		const client = await createClient();

		if (values.length == 0) {

	if (values.length == 0) {
	return { data: null, error: "No values provided." };
	}

	if (!op \|\| !column \|\| values.length == 0) {
	if (!op \|\| !column \|\| values.length === 0) {

		@@ -0,0 +1,45 @@
		import { createClient } from "../client/supabase/server";

		export async function filter_general(

		@@ -0,0 +1,64 @@
		import { describe, it, expect, beforeEach, afterEach } from "vitest";


		type VolunteerRow = Database["public"]["Tables"]["Volunteers"]["Row"];

		export async function filter_by_general_info(

Conversation

janiceelamm commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

ch-iv left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

notjackl3 Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

notjackl3 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

notjackl3 left a comment

Choose a reason for hiding this comment

Uh oh!

ch-iv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

janiceelamm commented Nov 21, 2025 •

edited

Loading

vercel bot commented Nov 21, 2025 •

edited

Loading

notjackl3 Jan 26, 2026 •

edited

Loading