Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements admin/volunteer CRUD endpoints for inventory items, including RBAC enforcement, soft-delete archival behavior, and barcode/UUID uniqueness validation, with accompanying tests for create/edit/delete flows.
Changes:
- Added
AdminCollectionItemViewSet(ModelViewSet) to support POST/PATCH/DELETE with role-based permissions and soft delete behavior. - Updated inventory routing to expose
/api/inventory/items/(admin/volunteer) alongside/api/inventory/public/items/(public read-only). - Introduced a writable admin serializer with
item_codeuniqueness validation and added CRUD-focused tests.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/inventory/views.py | Adds admin/volunteer CRUD ViewSet and soft-delete implementation. |
| backend/inventory/urls.py | Registers new admin routes and adjusts public route registration. |
| backend/inventory/serializers.py | Adds writable serializer and explicit uniqueness validation message for item_code. |
| backend/inventory/tests.py | Adds auth helpers/fixtures and tests for POST/PATCH/DELETE CRUD behavior. |
| .DS_Store | Adds an OS-generated artifact file (should not be committed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qiuethan
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30
Description
POST + PUT + DELETE REST api completed with RBAC + soft delete + barcode uniqueness
Acceptance Criteria
Test
Running test with following command should yeild 100% with close to 100% test coverage:
cd backend
source venv/bin/activate
pytest inventory/tests.py -v