Move README.coolify.md into .github/ so daily sync preserves it#2
Merged
Conversation
The sync workflow backs up only .github/ before `git reset --hard upstream/main`, so README.coolify.md at the repo root was wiped every night. patch.py's overwrite_readme() then silently no-op'd (file missing) and README.md reverted to upstream's stub. Caught by the first real sync run after the PR landed: README on main was upstream's "Ghost Docker" stub instead of the Coolify deploy guide. patch.py now reads .github/README.coolify.md and fails loudly if it's missing (since the sync is supposed to preserve it). test-patch.sh mirrors the new path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.coolify.md→.github/README.coolify.md.patch.pyreads from the new path and now fails loudly if the source is missing (instead of silently no-op'ing).test-patch.shmirrors the new layout.Why
The sync workflow backs up only
.github/beforegit reset --hard upstream/main, so the repo-rootREADME.coolify.mdwas wiped every night.patch.py'soverwrite_readme()was guarded byif src.exists():— no source meant no overwrite — soREADME.mdsilently reverted to upstream's "Ghost Docker" stub.Caught on the first dispatched run of
sync.ymlafter #1 landed.Test plan
bash .github/scripts/test-patch.shpasses with the new pathshellcheck .github/scripts/test-patch.shcleansync.yml; verifyREADME.mdonmainstarts with# Ghost on Coolify(not# Ghost Docker)🤖 Generated with Claude Code