Skip to content

Support custom known redirects in visitAll #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NullVoxPopuli merged 3 commits into from
Feb 6, 2026
Merged

Support custom known redirects in visitAll #110

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4a0a92
Support custom known redirects in visitAll
NullVoxPopuli Feb 6, 2026
508106b
Fix
NullVoxPopuli Feb 6, 2026
8fcfaae
Fix
NullVoxPopuli Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test-support/src/routing/visit-all.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ const assert = QUnit.assert;

export async function visitAllLinks(
callback?: (url: string) => void | Promise<void>,
knownRedirects?: Record<string, string>,
) {
/**
* string of "on::target"
Expand Down Expand Up @@ -108,10 +109,14 @@ export async function visitAllLinks(
debugAssert(`link exists via selector \`${toVisit.selector}\``, link);

await click(link);

const current = currentURL();
const expected = knownRedirects?.[current] ?? toVisit.href;

assert.pushResult({
result: currentURL().startsWith(toVisit.href),
actual: currentURL(),
expected: toVisit.href,
result: current.startsWith(expected),
actual: current,
expected: expected,
message: `Navigation was successful: to:${toVisit.original}, from:${returnTo}`,
});
visited.add(key);
Expand Down
Loading