Skip to content

Conversation

@Neerpatel125
Copy link
Contributor

@Neerpatel125 Neerpatel125 commented Jul 18, 2025

Description

This PR focuses on storing additional QED-C metrics (circuit depth, width, 2-Qubit gates, etc.) and plotting them. The files generated are stored in __data/ and __images/ after polling.

The execution time and circuit creation time plots have been excluded, and no additional dependencies were added. This will complete the implementation of the selected QED-C benchmarks.

Issue ticket number and link

N/A

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Each QED-C benchmark was ran and plotted using the local aer_simulator. To reproduce results, run the example schema files for each benchmark -- they will display extra metrics and associated plots. No configuration changes need to be made for testing purposes.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules (or not applicable)

Comment on lines 179 to 181
# Set backend information for plot titles.
provider_name = "qBraid"
device_name = "<unknown>"
Copy link
Contributor Author

@Neerpatel125 Neerpatel125 Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to get the provider_name and device_name when polling.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any clever ideas on how to do this, @cosenal ? My initial thought would be to change the arguments for the polling function, but this would require changes to all benchmarks and going forward as well. Maybe supporting some type of *kwargs for polling here is a reasonable approach?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed on Friday, this is likely something outside of scope for this MR but something that we should perhaps spin up a separate issue about as this is likely a use-case that will crop up again (@cosenal )

@vprusso vprusso requested a review from cosenal July 26, 2025 13:40
Copy link
Contributor

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's also get @cosenal to give a review of this as well. Nice work, @Neerpatel125 !

@Neerpatel125
Copy link
Contributor Author

As mentioned in today's meeting, I removed extra_metrics and plot_metrics from the schema files, and the code stores all metrics and plots them by default. We plan to move the plotting to a visualization step after polling or find other alternatives.

@Neerpatel125 Neerpatel125 changed the title Optionally Storing and Plotting Additional QED-C Metrics Storing and Plotting Additional QED-C Metrics Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants