-
Notifications
You must be signed in to change notification settings - Fork 12
Storing and Plotting Additional QED-C Metrics #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Storing and Plotting Additional QED-C Metrics #437
Conversation
Added code comments.
| # Set backend information for plot titles. | ||
| provider_name = "qBraid" | ||
| device_name = "<unknown>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to get the provider_name and device_name when polling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any clever ideas on how to do this, @cosenal ? My initial thought would be to change the arguments for the polling function, but this would require changes to all benchmarks and going forward as well. Maybe supporting some type of *kwargs for polling here is a reasonable approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed on Friday, this is likely something outside of scope for this MR but something that we should perhaps spin up a separate issue about as this is likely a use-case that will crop up again (@cosenal )
Co-authored-by: Vincent Russo <[email protected]>
Co-authored-by: Vincent Russo <[email protected]>
Co-authored-by: Vincent Russo <[email protected]>
Co-authored-by: Vincent Russo <[email protected]>
vprusso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's also get @cosenal to give a review of this as well. Nice work, @Neerpatel125 !
Also updated code comments.
|
As mentioned in today's meeting, I removed |
Description
This PR focuses on storing additional QED-C metrics (circuit depth, width, 2-Qubit gates, etc.) and plotting them. The files generated are stored in
__data/and__images/after polling.The execution time and circuit creation time plots have been excluded, and no additional dependencies were added. This will complete the implementation of the selected QED-C benchmarks.
Issue ticket number and link
N/A
Type of change
How Has This Been Tested?
Each QED-C benchmark was ran and plotted using the local
aer_simulator. To reproduce results, run the example schema files for each benchmark -- they will display extra metrics and associated plots. No configuration changes need to be made for testing purposes.Checklist: