ICU-23049 Re-enable UWP in CI #3781
Merged
+23
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARM 32 not supported in newer SDKs. `Build.Windows.UWP.ProjectConfiguration.props` now does what `Build.Windows.ProjectConfiguration.props` was already doing. I think that in an ideal world the uwp projects / properties should be a lot more similar to the non-uwp ones.
mihnita
force-pushed
the
mihai_ICU-23049
branch
from
80dd849 to
f365be9
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
markusicu
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert 743998d, 2024-11-21, "ICU-22977 Temp fix for MSVC builds: SkipUWP"
I didn't have to do anything, it looks like Visual Studio fixed whatever it was doing.
But starting with a certain version VS stopped supporting ARM32.
So I had to copy some conditions from a non UWP .props file to the UWP one.
I think that uwp/non-uwp projects and properties files should be a lot closer than they are, and share a lot more. But I didn't try to unify them.
Checklist