Enhancements Jmeter autostop plugin #729
Conversation
| @Override | ||
| public void sampleOccurred(SampleEvent se) { | ||
| SampleResult sr = se.getResult(); | ||
| statCalc.addSample(sr); |
There was a problem hiding this comment.
This can be resource consuming, from what I remember. Please enclose it into if(testValuePercentileRespTime > 0) {}, so it's only called when actually used.
There was a problem hiding this comment.
Thanks for the suggestion. Have moved it under if(testValuePercentileRespTime > 0) {}
| </Constraint> | ||
| </Constraints> | ||
| </Component> | ||
| <Component class="javax.swing.JLabel" name="jLabel13"> |
There was a problem hiding this comment.
Please attach to PR the screenshot of resulting UI, to review the visual
| log.debug(testPercentileValue+"Percentile Response >"+testValuePercentileRespTime+"until"+testValuePercentileRespTimeSec+"currentValue"+percentileResponseTime); | ||
| log.debug(testActualValue+">>"+testExpectedValue+">>"+skipIter+">>"+testValueCustomSec); | ||
| if(percentileResponseTime > testValuePercentileRespTime) { | ||
| log.dubeg((sec - percentileRespTimeExceededStart)+" "+getPercentileResponseTimeSecsAsInt()); |
There was a problem hiding this comment.
Typo. Have corrected and commented out. Thanks for the correction
| } | ||
| } | ||
|
|
||
| if(testValuePercentileRespTime > 0) { |
There was a problem hiding this comment.
This whole block of code is not formatted well
There was a problem hiding this comment.
Also excessive calls with concatenation will cost a lot of memory and CPU for JMeter
There was a problem hiding this comment.
Have formatted and commented out debug statements
|
Cool. |
|
Thanks |
Added auto-stop feature based on percentile value for response time.
Considering micro-services, this feature is helpful for latency sensitive application's where P95 and P99 are used to determine SLA breeches and stop the load automatically with the help of this plugin