fix: record missing when record count greater than 20 - #19
Open
EkkoG wants to merge 1 commit into
Open
Conversation
undefinedplayer
left a comment
undefinedplayer
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR. It'll be great to expose per_page as an parameter upstream to the main function and set it default to 100? In that case it would support the case if it has more than 100 records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the doc https://api.cloudflare.com/#dns-records-for-a-zone-list-dns-records
API only returns 1 page, and 20 records per page, so when record count greater than 20, some record will missing in local cache, then RecordNotFound occur. This patch changes the page size to 100, the max page size, to avoid the issue.