feat: 요일별 휴업 기능 적용 #131
Merged
feat: 요일별 휴업 기능 적용 #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99mini
reviewed
Aug 4, 2025
99mini
approved these changes
Aug 4, 2025
Member
99mini
left a comment
99mini
left a comment
There was a problem hiding this comment.
감사합니다~!
하나 제안사항으로 CustomeCheckbox라는 이름보다 Checkbox혹은 SquareCheckbox 제안합니다
Comment on lines
12
to
19
| const CustomCheckbox = ({ | ||
| checked, | ||
| onPress, | ||
| size = 18, | ||
| color = 'black', | ||
| }: CustomCheckboxProps) => { | ||
| return ( | ||
| <S.Container> |
Member
There was a problem hiding this comment.
그냥 Checkbox 라는 이름으로 사용해도 될 것같아요
아니면 사각형이니까 SquareCheckbox로 작명하고 추후 변경사항이 생기면 CircleCheckbox,...등등 추가하고 한 단계 추상화 컴포넌트를 만드는 것으로 확장하죠
Contributor
Author
There was a problem hiding this comment.
넵 좋습니다~! SquareCheckbox로 진행하겠습니다 👍
| <S.TimePickerButton | ||
| onPress={() => setOpenModal({type: 'open', index: idx})} | ||
| disabled={!isEditPermission || isClosed}> | ||
| {/* FIXME: openHours.openTime 타입 string으로 고정 */} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
저번 작업에서 openHour 내 시간들을 Date | string으로 제가 생성했었는데,
서버에서 string으로 주고있어 string으로 고정하면 어떨까 합니다!
기존 Date로 관리하던 값들을 string으로 변경했습니다.