LIBDRUM-909. Provide separate umdDescribe/mhheaDescribe form configs#272
Merged
dsteelma-umd merged 2 commits intodrum-mainfrom Apr 20, 2026
Merged
LIBDRUM-909. Provide separate umdDescribe/mhheaDescribe form configs#272dsteelma-umd merged 2 commits intodrum-mainfrom
dsteelma-umd merged 2 commits intodrum-mainfrom
Conversation
Fixes validation error display rendering by creating a separate "mhheaDescribe" form for use with Minority Health and Health Equity Archive submisions, modeled on the the standard "umdDescribe" form. This eliminates the need for a separate "Submission Type" panel from both forms. Having this separate panel appears to be the source of the error validation display issue. The "umdDescribe" and "mhheaDescribe" forms are commented with "custom" and "common" sections. The "custom" section in "umdDescribe" handles the dynamic display of the "Equitable Access" field when specific document types are selected. The "custom" section in "mhheaDescribe" does not have this functionality, as it is not needed. The "common" sections of both forms should remain in sync -- updates to one should be (manually) replicated in the other. There is no way to enforce this, other than through mentioning it in the documentation. https://umd-dit.atlassian.net/browse/LIBDRUM-909
Updated the "DrumSubmissionForms.md" and "DrumTestPlan.md" documents to reflect the changes made in this issue. https://umd-dit.atlassian.net/browse/LIBDRUM-909
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes validation error display rendering by creating a separate "mhheaDescribe" form for use with
Minority Health and Health Equity Archive submisions, modeled on the the standard "umdDescribe" form.
This eliminates the need for a separate "Submission Type" panel from both forms. Having this separate panel appears to be the source of the error validation display issue.
The "umdDescribe" and "mhheaDescribe" forms are commented with "custom" and "common" sections. The "custom" section in "umdDescribe" handles the dynamic display of the "Equitable Access" field when specific document types are selected. The "custom" section in "mhheaDescribe" does not have this functionality, as it is not needed.
The "common" sections of both forms should remain in sync -- updates to one should be (manually) replicated in the other. There is no way to enforce this, other than through mentioning it in the documentation.
https://umd-dit.atlassian.net/browse/LIBDRUM-909