Skip to content

Add a backing field for EditorUIAlias and track changes when its set. #19733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

KevinJump
Copy link
Contributor

Description

Fixes : #19732

The EditorUIAlias property in the DataType model was missing value tracking, so the Dirty methods (IsDirty, GetDirtyProperties, etc) where not registering any changes if this value is updated.

This PR adds the backing field and updates the get and set methods in the DataType model so tracking will pick up any changes.

  • Adds a new private string field _editorUIAlias to the DataType model.
  • Uses this as the backing field for EditorUIAlias property
  • Update Set method to call SetPropertyValueAndDetectChanges when the value is set

@Copilot Copilot AI review requested due to automatic review settings July 15, 2025 09:56
Copy link

Hi there @KevinJump, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables change tracking for the EditorUiAlias property by introducing a backing field and using the SetPropertyValueAndDetectChanges method in its setter.

  • Adds a private nullable string field _editorUIAlias to the DataType model
  • Converts EditorUiAlias from an auto-property to a full property with change detection
Comments suppressed due to low confidence (1)

src/Umbraco.Core/Models/DataType.cs:64

  • Consider adding unit tests to verify that setting EditorUiAlias correctly marks the DataType instance as dirty and appears in GetDirtyProperties.
    public string? EditorUiAlias

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KevinJump - looks good to me. I just added a unit test that fails before your proposed update is applied, to verify the fix.

@AndyButland AndyButland enabled auto-merge (squash) July 21, 2025 07:07
@AndyButland AndyButland merged commit 6fe39b0 into umbraco:main Jul 21, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataType member EditorUIAlias does not set member or item as dirty when set.
2 participants