V16 QA Implement new release tag for E2E tests #19697
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andr317c
requested changes
Jul 11, 2025
Comment on lines
+874
to
+882
| WindowsPart1Of3: | ||
| vmImage: "windows-latest" | ||
| testCommand: "npm run releaseTest -- --shard=1/3" | ||
| WindowsPart2Of3: | ||
| vmImage: "windows-latest" | ||
| testCommand: "npm run releaseTest -- --shard=2/3" | ||
| WindowsPart3Of3: | ||
| vmImage: "windows-latest" | ||
| testCommand: "npm run releaseTest -- --shard=3/3" |
There was a problem hiding this comment.
We don't have that many release tagged tests, so 2 runners might be fine, and what about linux?
| @@ -83,7 +83,7 @@ for (const dataTypeName of dataTypeNames) { | |||
| }); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Might not be needed, as we also have a test for 'can not publish a mandatory checkbox list with an empty value' with the release tag
| @@ -84,7 +84,7 @@ test('can create content with the custom radiobox data type', async ({umbracoApi | |||
| expect(contentData.values[0].value).toEqual(optionValues[0]); | |||
| }); | |||
|
|
|||
| test('can not publish mandatory radiobox with an empty value', async ({umbracoApi, umbracoUi}) => { | |||
| test('can not publish mandatory radiobox with an empty value', {tag: '@release'}, async ({umbracoApi, umbracoUi}) => { | |||
There was a problem hiding this comment.
Might not be needed, as we also have a test for 'can not publish a mandatory checkbox list with an empty value' with the release tag
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithTextstring.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes
Description