Fix missing tag suggestions when no culture available. #19694
Merged
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes: #19693
Description
As per issue description, when the Tags property editor is used inside an
umb-property-dataset
element the culture provided to the property editor is null.I found that culture is not required by the Tag's Repository, Data Source, or Management API. So, the check for undefined value is not needed. I've modified the code to replace undefined values with null which can be handled by the subsequent call chain.
I've tested this by modifying the
dashboard-with-property-dataset
example with the following additions (not committed)Added additional property to data set.
Added the tags property editor to the dashboard with configuration