moc: fix type mismatch in moc_data #2288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moc.py was recently refactored by f648cb6 ("py3: add new helper: get_replacements_list"). This causes it to fail when MOC is started, because the code has two variables: * `moc_data`, which is a `str`. * `data`, which is a `dict`. But the refactor accidentally handles `moc_data` as a `dict`. This commit fixes the issue, and unifies `data` and `moc_data`, using the same pattern that is already being used in cmus.py.
lasers
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moc.py was recently refactored by f648cb6 ("py3: add new helper: get_replacements_list").
This causes it to fail when MOC is started, because the code has two variables:
moc_data, which is astr.data, which is adict.But the refactor accidentally handles
moc_dataas adict.This commit fixes the issue, and unifies
dataandmoc_data, using the same pattern that is already being used in cmus.py.