playerctl: Ensure duration and position are always integers #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, a player could return its position in the song as a float (e.g. SMPlayer), but the module expects it to be an integer (causing an error while formatting the time). This commit ensures that the duration will always be an integer before formatting the time.
lasers
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, a player could return its position/duration in the song as a float (e.g. SMPlayer), but the module expects it to be an integer (causing an error while formatting the time). This commit ensures that the position/duration will always be an integer before formatting the time, as both arguments to
divmodwill always be integers (thus, returning an integer).