Skip to content

Conversation

@mingchen-NOAA
Copy link
Collaborator

@mingchen-NOAA mingchen-NOAA commented Nov 24, 2025

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

This PR addresses multiple compiler warnings and update WW3 to the current develop branch.

A full set of Intel and GNU UFSWM RT tests was performed. Three changes were observed due to run-time timeouts.
NOTE: These changes do not involve the wave model.

regional_control intel
regional_restart intel
regional_2dwrtdecomp intel

Commit Message:

* UFSWM - updates WW3 and resolves compiler warnings
  * WW3 - Addresses compiler warnings and updates WW3 to current develop branch

Priority:

  • Critical Bugfix: Reason
  • High: Reason
  • Normal: Addresses compiler warnings for GFSv17

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • Blocked by #
  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).
  • Documentation update NOT required.
    • Explanation: Routine update with develop of WW3 + compile warning fixes

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.
  • PR Updates/Changes Baselines.
  • No Baseline Changes.

Input data Changes:

  • None.
  • PR adds input data.
  • PR changes existing input data.

Library Changes/Upgrades:

  • Required
    • Library names w/versions:
    • Git Stack Issue (JCSDA/spack-stack#)
  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

…community#2971)

* UFSWM - address unreasonable large F0 and F1 in entrainment calculation - 2971
  * UFSATM - address unreasonable large F0 and F1 in entrainment calculation - 1033
    * ccpp-physics - address unreasonable large F0 and F1 in entrainment calculation - 327
@gspetro-NOAA gspetro-NOAA added WW3 There are changes to the WW3 component repository. No Baseline Change No Baseline Change labels Nov 25, 2025
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review in PRs to Process Nov 25, 2025
@gspetro-NOAA
Copy link
Collaborator

@mingchen-NOAA Since the failed tests were timeouts that don't involve WW3, could you remove them from test_changes.list?

mingchen-NOAA and others added 5 commits November 28, 2025 15:26
…ling issues with ORT testing ufs-community#2982 // Update CICE (2025-11) ufs-community#2989 (ufs-community#2406)

* UFSWM - Remove local copies of FindESMF.cmake from all components
* UFSWM - Fix labeling issues with ORT testing; update Jenkins to use Slack notifications plugin
* UFSWM - Update CICE (2025-11)
  * CICE - Update CICE (2025-11)
  * AQM - Remove local copy of FindESMF.cmake
  * FV3 - Remove local copy of FindESMF.cmake
    * atmos_cubed_sphere - Remove local copy of FindESMF.cmake
  * WW3 - Remove local copy of FindESMF.cmake
  * LM4 - Remove local copy of FindESMF.cmake
@gspetro-NOAA
Copy link
Collaborator

@mingchen-NOAA @dpsarmie has pulled your PR changes into his PR #2979, so any further changes should be added there. This looks like it's only a WW3 hash update though, right?

@mingchen-NOAA
Copy link
Collaborator Author

@gspetro-NOAA Yes, only updated WW3 hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No Baseline Change WW3 There are changes to the WW3 component repository.

Projects

Status: Schedule

Development

Successfully merging this pull request may close these issues.

4 participants