-
Notifications
You must be signed in to change notification settings - Fork 275
Fix compilation warnings and update WW3 #3000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mingchen-NOAA
wants to merge
8
commits into
ufs-community:develop
Choose a base branch
from
mingchen-NOAA:ww3update2dev
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…community#2971) * UFSWM - address unreasonable large F0 and F1 in entrainment calculation - 2971 * UFSATM - address unreasonable large F0 and F1 in entrainment calculation - 1033 * ccpp-physics - address unreasonable large F0 and F1 in entrainment calculation - 327
Collaborator
|
@mingchen-NOAA Since the failed tests were timeouts that don't involve WW3, could you remove them from |
22 tasks
…ling issues with ORT testing ufs-community#2982 // Update CICE (2025-11) ufs-community#2989 (ufs-community#2406) * UFSWM - Remove local copies of FindESMF.cmake from all components * UFSWM - Fix labeling issues with ORT testing; update Jenkins to use Slack notifications plugin * UFSWM - Update CICE (2025-11) * CICE - Update CICE (2025-11) * AQM - Remove local copy of FindESMF.cmake * FV3 - Remove local copy of FindESMF.cmake * atmos_cubed_sphere - Remove local copy of FindESMF.cmake * WW3 - Remove local copy of FindESMF.cmake * LM4 - Remove local copy of FindESMF.cmake
Collaborator
|
@mingchen-NOAA @dpsarmie has pulled your PR changes into his PR #2979, so any further changes should be added there. This looks like it's only a WW3 hash update though, right? |
Collaborator
Author
|
@gspetro-NOAA Yes, only updated WW3 hash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description:
This PR addresses multiple compiler warnings and update WW3 to the current develop branch.
A full set of Intel and GNU UFSWM RT tests was performed. Three changes were observed due to run-time timeouts.
NOTE: These changes do not involve the wave model.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: