address unreasonable large F0 and F1 in entrainment calculation #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnningCheng-NOAA
requested review from
JongilHan66,
Qingfu-Liu,
dustinswales,
grantfirl,
lisa-bengtsson and
rhaesung
as code owners
JongilHan66
approved these changes
Nov 5, 2025
rhaesung
approved these changes
Nov 6, 2025
rhaesung
approved these changes
Nov 6, 2025
grantfirl
approved these changes
Nov 6, 2025
lisa-bengtsson
approved these changes
Nov 14, 2025
|
Testing for #2971 is complete, please continue with merging, thank you. |
This was referenced Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
The parameters F0 and F1 which represent environmental moisture deficiency and govern the entrainment rate in the SAS deep convection scheme, exhibit an issue when aerosol-cloud interactions (ACIs) are active in seasonal-to-seasonal forecasts. Specifically, these parameters can become unexpectedly large, leading to a model crash. A solution is to limit F0 < 3, suggested by Jongil
Tests Conducted:
Explicitly state what tests were run on these changes, or if any are still pending (for README or other text-only changes, just put "None required". Make note of the compilers used, the platform/machine, and other relevant details as necessary. For more complicated changes, or those resulting in scientific changes, please be explicit!
OR Add any links to tests conducted. For example, "See ufs-community/ufs-weather-model#<pr_number>"
Dependencies:
Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:
Documentation:
Does this PR add new capabilities that need to be documented or require modifications to the existing documentation? If so, brief supporting material can be provided here. Contact the CODEOWNERS if your PR requires extensive updates to the documentation. See https://github.com/NCAR/ccpp-doc for Technical Documentation or https://dtcenter.org/community-code/common-community-physics-package-ccpp/documentation for the latest Scientific Documentation.
Issue (optional):
If this PR is resolving or referencing one or more issues, in this repository or elewhere, list them here. For example, "Fixes issue mentioned in #123" or "Related to bug in NCAR/other_repository#123"
fixes issue ufs-community/ufs-weather-model#2968
Contributors (optional):
If others have contributed to this work aside from the PR author, list them here