Tendency application update #299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove *_of_new_state (default name refers to 'current' value)
…medmfvdifq return new tendencies and new tendency application block in GFS_PBL_generic_post
- Added tendency variables (`ten_t`, `ten_u`, `ten_v`) for temperature and wind tendencies in SAMF deep and shallow convection schemes. - Updated relevant `.meta` files to reflect changes in variable intent (`inout` -> `in` where appropriate) and added tendencies. - Modified Interstitials (`GFS_DCNV_generic_post`, `GFS_DCNV_generic_pre`, `GFS_SCNV_generic_post`, `GFS_SCNV_generic_pre`) to directly use tendencies instead of saved state variables. - Removed redundant saved variables (`save_u`, `save_v`, `save_t`). - Added `delt` to post interstitials.
…' into feature/tendency_cleanup
…_dimension in GFS_time_vary_pre.scm
…endency paradigm; cleanup saving of states no longer needed
…as removed recently
grantfirl
requested review from
AndersJensen-NOAA,
AnningCheng-NOAA,
BoYang-NOAA,
JongilHan66,
MicroTed,
RuiyuSun,
SamuelTrahanNOAA,
Songyou184,
WeiguoWang-NOAA,
XuLi-NOAA,
ZhanZhang-NOAA,
andrewgettelman,
barlage,
cenlinhe,
ericaligo-NOAA,
gthompsnWRF,
joeolson42,
mdtoyNOAA,
mzhangw,
tanyasmirnova and
yangfanglin
as code owners
MicroTed
reviewed
Aug 17, 2025
| real(kind_phys), intent( out) :: ten_chw(:,:) | ||
| real(kind_phys), intent( out), optional :: ten_chl(:,:) | ||
| real(kind_phys), intent( out) :: ten_vh(:,:) | ||
| real(kind_phys), intent( out) :: ten_vhl(:,:) |
Collaborator
There was a problem hiding this comment.
ten_vhl would also be optional like qhl, chl (all are hail variables)
MicroTed
reviewed
Aug 17, 2025
| if ( nssl_3moment ) then | ||
| ten_zrw = 0.0 | ||
| ten_zhw = 0.0 | ||
| ten_zhl = 0.0 |
Collaborator
There was a problem hiding this comment.
Need another if test for the hail reflectivity (zhl):
if (nssl_hail_on) then
ten_zhl = 0.0
endif
mdtoyNOAA
approved these changes
Aug 18, 2025
Collaborator
mdtoyNOAA
left a comment
mdtoyNOAA
left a comment
There was a problem hiding this comment.
Everything looks good from a UGWP standpoint.
barlage
approved these changes
Aug 19, 2025
JongilHan66
approved these changes
Aug 19, 2025
haiqinli
approved these changes
Aug 19, 2025
Qingfu-Liu
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes:
See https://docs.google.com/presentation/d/1LJbCrCVGYDvm0UPo8SR4KP6fT1VFocg-xLG399qGQ1w/edit?slide=id.g371ddcb3c06_0_238#slide=id.g371ddcb3c06_0_238 for a complete description.
Main points:
Tests Conducted:
See the linked slides. This was tested in the following ways:
Dependencies:
None
Documentation:
TODO
Issue (optional):
None
Contributors (optional):
@grantfirl @VanderleiVargas-NOAA