Skip to content

Conversation

@DeniseWorthen
Copy link
Contributor

@DeniseWorthen DeniseWorthen commented Nov 24, 2025

DESCRIPTION OF CHANGES:

Adds 1/12 deg ocean and ice grid file generation.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Ursa, Hercules and WCOSS2).
  • Compile branch on Ursa using GNU. ee4a46a
  • Compile branch in 'Debug' mode on WCOSS2. 49b3d98
  • Compile with Doxygen on any machine with no errors. ee4a46a
  • Run unit tests locally on any Tier 1 machine. ee4a46a
  • Run relevant consistency tests locally on all Tier 1 machines.

Optional test.

  • Run full set of chgres_cube consistency tests on Ursa.

Describe any additional tests performed.

DEPENDENCIES:

The MOM6 supergrid, bathymetry and mask files need to be added to the glopara fix directories. Currently the rt.sh for the utility is pointing to a staged set of 1/12deg input data.

ISSUE:

@DeniseWorthen
Copy link
Contributor Author

@BrianCurtis-NOAA Please assign me. Thanks.

@DeniseWorthen DeniseWorthen marked this pull request as ready for review November 25, 2025 15:46
@DeniseWorthen
Copy link
Contributor Author

DeniseWorthen commented Nov 25, 2025

@BrianCurtis-NOAA I don't intend on retaining baselines for the 1/12 deg at this time, since it is unclear whether RTOFS will use any of the additional files generated (and they're big files, ~4GB).

The setting in rt.conf which will generate the needed grid files for the mx008 case is

diff --git a/reg_tests/cpld_gridgen/rt.conf b/reg_tests/cpld_gridgen/rt.conf
index c908c5f6..9618010d 100644
--- a/reg_tests/cpld_gridgen/rt.conf
+++ b/reg_tests/cpld_gridgen/rt.conf
@@ -14,8 +14,9 @@

 # TEST_NAME | ATMRESLIST

- mx025 | 48,96,192,384,768,1152
- mx050 | 48,96,192,384,768,1152
- mx100 | 48,96,192,384,768,1152
- mx500 | 24,48,96,192,384,768,1152
- mx900 | 12,24
+# mx025 | 48,96,192,384,768,1152
+# mx050 | 48,96,192,384,768,1152
+# mx100 | 48,96,192,384,768,1152
+# mx500 | 24,48,96,192,384,768,1152
+# mx900 | 12,24
+ mx008 | -99

In this case, since we're only using a DATM, there is no need to generate any mapped ocean masks on the ATM tiles, so the ATM resolutions are set to a null value.

I can run the cpld_gridgen baselines and verify that they don't change. What other testing should I do?

DeniseWorthen and others added 3 commits November 30, 2025 12:45
* all baselines pass
* cpld_gridgen unit test passes
* gnu compile succeeds
* doxygen build succeeds
@BrianCurtis-NOAA
Copy link
Collaborator

run the reg_tests for the component your modifying, verify it compiles, and the unit testing doesn't fail. If there's any documentation changes needed, please make them.

@DeniseWorthen
Copy link
Contributor Author

@BrianCurtis-NOAA I remember asking George this also....the PR template asks to confirm compilation w/ Intel, but AFAIK intelllvm is the compiler used by UFS_UTILS. Does the PR template need to be updated, or is the request to actually compile w/ Intel?

@BrianCurtis-NOAA
Copy link
Collaborator

@BrianCurtis-NOAA I remember asking George this also....the PR template asks to confirm compilation w/ Intel, but AFAIK intelllvm is the compiler used by UFS_UTILS. Does the PR template need to be updated, or is the request to actually compile w/ Intel?

template update is on my todo

@DeniseWorthen
Copy link
Contributor Author

OK, thanks. I think I've completed all the checkmarks then. All current baselines pass, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 1/12deg OCN/ICE configuration to cpld_gridgen

2 participants