-
Notifications
You must be signed in to change notification settings - Fork 126
Add generation of 1/12deg grid files for ocean and ice #1116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add generation of 1/12deg grid files for ocean and ice #1116
Conversation
* temp setting of input directory, wall clock
|
@BrianCurtis-NOAA Please assign me. Thanks. |
|
@BrianCurtis-NOAA I don't intend on retaining baselines for the 1/12 deg at this time, since it is unclear whether RTOFS will use any of the additional files generated (and they're big files, ~4GB). The setting in In this case, since we're only using a DATM, there is no need to generate any mapped ocean masks on the ATM tiles, so the ATM resolutions are set to a null value. I can run the cpld_gridgen baselines and verify that they don't change. What other testing should I do? |
* all baselines pass * cpld_gridgen unit test passes * gnu compile succeeds * doxygen build succeeds
|
run the reg_tests for the component your modifying, verify it compiles, and the unit testing doesn't fail. If there's any documentation changes needed, please make them. |
|
@BrianCurtis-NOAA I remember asking George this also....the PR template asks to confirm compilation w/ Intel, but AFAIK intelllvm is the compiler used by UFS_UTILS. Does the PR template need to be updated, or is the request to actually compile w/ Intel? |
template update is on my todo |
|
OK, thanks. I think I've completed all the checkmarks then. All current baselines pass, as expected. |
DESCRIPTION OF CHANGES:
Adds 1/12 deg ocean and ice grid file generation.
TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
Optional test.
Describe any additional tests performed.
DEPENDENCIES:
The MOM6 supergrid, bathymetry and mask files need to be added to the glopara fix directories. Currently the
rt.shfor the utility is pointing to a staged set of 1/12deg input data.ISSUE: