update archives using AI sponsored by microsoft #222
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
package.json
Outdated
| @@ -5,6 +5,7 @@ | |||
| "scripts": { | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "export": "next build && next export", | |||
There was a problem hiding this comment.
Do we need to leave this in? It's unlikely that anyone will ever have to manually export the website, and next export should complain that you need to run next build first :D
Co-authored-by: Copilot <[email protected]>
pages/archive.tsx
Outdated
| ); | ||
| }) => { | ||
| // Create a URL-friendly ID from the quarter name | ||
| const quarterId = quarter.name.toLowerCase().replace(/\s+/g, "-"); |
There was a problem hiding this comment.
copilot, this is unnecessary; we currently throw away the original quarterId after parsing Cyanea information in data.tsx, but we should just preserve that information in the QuarterArchive interface and reuse it here
pages/archive.tsx
Outdated
| // Check tags/type | ||
| if (typeof event.type === "string") { | ||
| if (event.type.toLowerCase().includes(lowerQuery)) return true; | ||
| } else if (event.type !== null && event.type !== undefined) { |
There was a problem hiding this comment.
oops i changed this from Array.isArray earlier but now I realize that that is probably a better way of putting this condition
pages/archive.tsx
Outdated
| // Create a unique ID combining quarter and series names | ||
| const seriesId = `${quarterName}-${series.name}` | ||
| .toLowerCase() | ||
| .replace(/\s+/g, "-"); |
There was a problem hiding this comment.
same here - use the original quarterId
styles/Archive.module.scss
Outdated
| @@ -20,9 +126,10 @@ | |||
| border: var(--cyber-gold) 2px solid; | |||
| border-radius: 2rem; | |||
| width: 20rem; | |||
| height: 17rem; | |||
| min-height: 17rem; // Changed to min-height for flexibility | |||
There was a problem hiding this comment.
please remove copilot's "Increased" / "Changed" comments :D
styles/Archive.module.scss
Outdated
| max-width: 8rem; | ||
| } | ||
|
|
||
| // More specific selector to override .section span without !important |
styles/Archive.module.scss
Outdated
| font-family: inherit; /* ??? override user-agent stylesheet for button */ | ||
| text-align: left; | ||
| scroll-margin-top: 6rem; // Increased offset for fixed navbar |
styles/Archive.module.scss
Outdated
|
|
||
| // Anchor link styling for quarters | ||
| h2 { | ||
| scroll-margin-top: 6rem; // Increased offset for fixed navbar |
styles/Archive.module.scss
Outdated
|
|
||
| // Anchor link styling for series | ||
| h3 { | ||
| scroll-margin-top: 6rem; // Increased offset for fixed navbar |
pages/archive.tsx
Outdated
| <div className={popUpStyle["popup"]}> | ||
| <div | ||
| className={popUpStyle["popup"]} | ||
| onClick={(e) => e.stopPropagation()} // Prevent closing when clicking inside popup |
There was a problem hiding this comment.
either remove this copilot comment or apply it to all of the onClick={(e) => e.stopPropagation()}
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive search and navigation system for the archive page, enhancing user experience with filtering capabilities and improved accessibility. The changes focus on making the archive more interactive and user-friendly while maintaining the existing cyberpunk aesthetic.
- Adds a search functionality that filters events by title, description, and tags
- Implements anchor links for quarters and series with smooth scrolling navigation
- Enhances responsive design and accessibility features across components
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
styles/Archive.module.scss |
Adds extensive styling for search components, anchor links, responsive design improvements, and better text overflow handling |
pages/archive.tsx |
Implements search functionality, filtering logic, anchor link generation, and accessibility improvements including lazy loading |
data/archive.ts |
Adds unique ID field to QuarterArchive interface to support anchor linking |
pages/archive.tsx
Outdated
| @@ -118,7 +251,11 @@ const Event = ({ | |||
| <span> | |||
| <img className={styles.icon} src="/images/slides.svg" /> | |||
There was a problem hiding this comment.
This image element is missing alt text and loading attributes that were added to other similar images in the same diff. This creates inconsistency in accessibility support.
| <img className={styles.icon} src="/images/slides.svg" /> | |
| <img className={styles.icon} src="/images/slides.svg" alt="Slides icon" loading="lazy" /> |
Copilot uses AI. Check for mistakes.
No description provided.