chore: enable Fedora 43 builds #1155
Merged
+68
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer-toolkit in F43
this bypasses the rpm-ostree/dracut operations which were causing the build to fail on F43 there are a few ideas commented out in addition to the least impacting solution I came up with.
castrojo
approved these changes
Oct 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables Fedora 43 builds by adding necessary configuration and working around compatibility issues with packages that don't yet support F43 or RPM 6.
Key Changes:
- Adds Fedora 43 image definitions and digests to support F43 builds
- Conditionally excludes nvidia-container-toolkit from F43 due to RPM 6 incompatibility
- Implements workarounds for kernel installation issues specific to F43
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages.json | Moves incompatible packages (android-udev-rules, mesa-libxatracker, pipewire-libs-extra) from global includes to F41/F42-specific includes, excluding them from F43 |
| image-versions.yaml | Adds Fedora 43 image definitions including akmods, base-atomic, silverblue, and kinoite with their respective digests |
| build_files/nvidia-install.sh | Makes nvidia-container-toolkit installation conditional, skipping it on F43 due to RPM 6 incompatibility |
| build_files/install.sh | Adds workaround shimming kernel-install scripts to bypass dracut/rpm-ostree during kernel RPM installation on F43 |
| .github/workflows/build-beta.yml | Re-enables pull_request and merge_group triggers for the beta build workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
inffy
approved these changes
Oct 15, 2025
Contributor
@p5 thank you for the clear call outs on what's missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled packages for F43: