fix: _scan_payload_sync fallback handler #43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Interestingly, there also seems to be a bug in the tests for the fallback behavior, which is why this went undetected. I'm going to look a little more deeply into that and see if I can fix it. |
ubernostrum
added a commit
that referenced
this pull request
Mar 9, 2025
This also fixes the tests for hte fallback behavior, which were incorrect and as a result masked the fact that the fallback was being used incorrectly in the sync path. Thanks Aguswahyudi Steven for noticing the bug with the fallback, and for the initial patch.
ubernostrum
added a commit
that referenced
this pull request
Mar 9, 2025
This also fixes the tests for hte fallback behavior, which were incorrect and as a result masked the fact that the fallback was being used incorrectly in the sync path. Thanks Aguswahyudi Steven for noticing the bug with the fallback, and for the initial patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
_fallback()handler in_scan_payload_sync()always receives thekeyinstead of the actual password