Bump to 4.5.0, add reverseDirectedEdge#230
Merged
Merged
Conversation
Coverage Report for CI Build 27454616134Warning No base build found for commit Coverage: 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
isaacbrodsky
marked this pull request as ready for review
June 8, 2026 20:06
dfellis
reviewed
Jun 9, 2026
| const vertices0 = h3.h3ToGeoBoundary(h3Indexes[0]); | ||
| const vertices1 = h3.h3ToGeoBoundary(h3Indexes[1]); | ||
| const expected = [[vertices0], [vertices1]]; | ||
| const expected = [[vertices1], [vertices0]]; |
Collaborator
There was a problem hiding this comment.
This change makes a kind of sense to me; what we actually wanted to test was that the Set of vertices in multiPolygon matches the expected set, but the order has now changed due to a different algorithm.
nrabinowitz
reviewed
Jun 12, 2026
nrabinowitz
left a comment
Collaborator
There was a problem hiding this comment.
This all looks good to me, but I do think @dfellis's question on accuracy is valid - do we know why this has regressed?
nrabinowitz
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to H3 v4.5.0, adds reverseDirectedEdge, and applies related test fixes.
Note: we will need to fix the following tests: