makisu pull: add support for --registry-config#359
makisu pull: add support for --registry-config#359lbpdt wants to merge 1 commit intouber-archive:masterfrom
Conversation
aad9b0f to
8e8ccd4
Compare
|
Hi @sema, would you be able to review this feature? Also, it looks like the Fossa check on Travis has been failing for the past couple months, if that's something you can fix. |
|
I implemented something similar in #354. It also seemed that deleting the DockerHubRegistry code was needed to allow pulling from docker.io. The rest of makisu only allows configuration with It's a little confusing to leave the hardcoded docker.io config if this registry-config option is added, because it cannot be overridden (I think so at least). |
8e8ccd4 to
470bc53
Compare
|
@bburky yours is very similar indeed, but with a larger scope than what I'm doing here. You could also rebase your PR on top of |
|
Build is now failing due to rate limiting on DockerHub. I'll kick it again is a couple hours.
EDIT: build now passes but the Fossa check is still missing an API key... |
This is useful to authenticate with the registry when pulling images.
470bc53 to
7c79732
Compare
This is useful to authenticate with the registry when pulling images.