Skip to content

[11.0 Port] Fix a few bugs due to PHP7 (#140) #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aestoltm wants to merge 2 commits into
base: xdmod11.0
Choose a base branch
from
Open

[11.0 Port] Fix a few bugs due to PHP7 (#140) #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb95c5f
Fix a few bugs due to PHP7 (#140)
aestoltm Nov 26, 2025
40001ab
Merge branch 'xdmod11.0' into port_fix_method_overload
aestoltm Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/DataWarehouse/Access/DataExplorer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public function get_ak_plot($user)
$chart->setTitle($show_title?($title):NULL, $font_size);
$chart->setLegend($legend_location, $font_size);//called before and after
$show_closest_hover_label = count($datasets) > 1;
$chart->configure($datasets,
$chart->configureAppKernelChart($datasets,
$font_size,
$limit,
$offset,
Expand Down
2 changes: 1 addition & 1 deletion classes/DataWarehouse/Visualization/AppKernelChart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function __construct(
$this->_indicator_url = '/gui/images/exclamation_ak.png';
}

public function configure(
public function configureAppKernelChart(
&$datasets,
$font_size = 0,
$limit = null,
Expand Down
4 changes: 2 additions & 2 deletions classes/Rest/Controllers/AppKernelControllerProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ public function getPlots(Request $request, Application $app)
$chart->setLegend($legend_location, $font_size);

$datasets = array();
$chart->configure(
$chart->configureAppKernelChart(
$datasets,
$font_size,
$limit,
Expand Down Expand Up @@ -579,7 +579,7 @@ public function getPlots(Request $request, Application $app)

if ($format != 'params') {
$datasets = array($result);
$chart->configure(
$chart->configureAppKernelChart(
$datasets,
$font_size,
$limit,
Expand Down