-
Notifications
You must be signed in to change notification settings - Fork 16
Windows builds #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Windows builds #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10481db to
7a436dd
Compare
`ssize_t` isn't available on windows and `nghttp2_ssize` was introduced in v1.60.0. Ref: nghttp2/nghttp2#616
7a436dd to
ef2da87
Compare
ef2da87 to
fa69bda
Compare
uatuko
commented
Nov 2, 2024
tchernobog
reviewed
Nov 4, 2024
tchernobog
reviewed
Nov 4, 2024
0bc650a to
9c5b8dd
Compare
9c5b8dd to
b7ab0b1
Compare
tchernobog
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssize_t(a28b439)Unresolved issues
1. Examples can't be built
Looks like there's an issue with protobuf (or cmake configs) where it's failing to find
protoc?2. Error C2894 when building with libuv
Build logs
Ref: https://github.com/uatuko/grpcxx/actions/runs/11645652496/job/32428922875