Cleanup of the code #192
Open
Cleanup of the code #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm not too experienced in Python, but over the coming period my plan is to create a pull request that adds update entities to your integration - as my personal goal would be to easily manage all my docker containers using your integration!
This PR contains some simple changes that I've made while familiarizing myself with the code. I tried to split them in clear separate commits. It's my first online PR outside some software related experience in my previous job, so if there are do's/don'ts or feedback I'm all ears!
Also: I've removed the find_rename function, as it is no longer used. This also implies that the
renamedictionary in theconfiguration.yamlno longer works if people would set it up without the UI. Do you want me to make changes to the README accordingly?