Expose list of known namespaces - #7
Merged
Merged
Conversation
laurmaedje
reviewed
Aug 3, 2026
laurmaedje
left a comment
laurmaedje
left a comment
Member
There was a problem hiding this comment.
I get the desire for a macro, but honestly I find the non-macro version more readable and easier to understand, not least because the URLs are all together and the prefixes are all together. I think the bit of extra verbosity in rarely edited code is not a big deal.
NiklasEi
force-pushed
the
expose-known-namespaces
branch
from
August 5, 2026 19:35
7a00f39 to
9810bc0
Compare
Contributor
Author
|
I reverted the macro and moved the jobs changes to a separate PR. The list is now an associated const slice. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the list of known namespaces. I moved all the namespace related things into a macro to keep everything consistent.
Context: LaurenzV/krilla#408 (comment)
The description ofXmpJoblooked like copy paste fromXmpJobManagementand I changed it.jobswas also writing the wrong property.