-
-
Notifications
You must be signed in to change notification settings - Fork 11
Add Unicode 15.0 emojis (minus sequences) #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to wait before merging!
I realized that there's at least two changes that should likely be made here. Khanda should go under faith, and hyacinth should go under flower. (Speaking of which, there are some really weirdly named emojis under faith) |
Unicode lists |
Cyan specifically means a greenish hue of blue, which the Unicode name doesn't specify |
Where do you see that? |
I think they mean https://www.unicode.org/L2/L2021/21202-light-blue-heart-emoji.pdf, but that's just part of the proposal. It's not an official thing. If you look at the actual implementations on https://emojipedia.org/light-blue-heart#designs using a color picker they all lean more heavily on blue than teal typically would (unlike in the proposal). So I think lighblue is more appropriate. Edit: Okay, the keyword is official. However, I maintain that light blue is a better description for the actual implementations. |
https://www.unicode.org/emoji/charts-15.0/emoji-released.html |
As always it's frustrating that unicode data is "organized" in such a haphazard manner. |
I mean there's some green in there, but look at https://en.wikipedia.org/wiki/Cyan. I think it applies well enough to many of the actual implementations. Edit: fixed link |
The implementations all have higher blue than green values, while cyan typically has about equal blue and green value. |
Many of the listed examples have green:blue of 12:15 to 14:15, which could be considered close enough. But I'll let this be my final argument. @MDLC01 what do you think? |
I also feel like I've said everything I've wanted to, and will defer to the majority. |
All implementations look more light blue than cyan to me. The values of the RGB color channels don't really matter in my opinion, as RGB (or sRGB, or linear RGB, or whatever the right terminology is in this case) is not a perceptual color space. I understand the desire to have shorter names, especially when it means we don't have two words in a single identifier, but in this case I tend to be in favor of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Let's leave this open for a bit to give others the opportunity to also comment on this.
I also prefer lightblue: it just seems more correct as it matches the CLDR short name and the implementations. For "wireless" I think it's the right choice: as you say "wifi" might be too specific, and it's a trademark with its own logos (see https://www.wi-fi.org/system/files/Wi-Fi_Alliance_Brand_Style_Guide_202504_0.pdf) |
Based on the discussion it seems there is consensus enough to merge this as it is. |
The names should be fairly uncontroversial. We already had all 16.0 ones, and 15.1 consists only of sequences.
I was considering using "wifi" for the wireless one, but I think it can be used for other wireless technologies.
p.s. I think the current list isn't quite in alphabetical order.