Add support for typed custom-elements and web-components - #1016
Draft
NullVoxPopuli wants to merge 7 commits into
Draft
Add support for typed custom-elements and web-components#1016NullVoxPopuli wants to merge 7 commits into
NullVoxPopuli wants to merge 7 commits into
Conversation
NullVoxPopuli
changed the title
NullVoxPopuli
force-pushed
the
nvp/test-typed-custom-elements
branch
from
December 29, 2025 15:56
c5855c2 to
5fa525f
Compare
Contributor
|
Superseded by #1212, which rebuilds this on current main (name-keyed registries: |
NullVoxPopuli-ai-agent
added a commit
to NullVoxPopuli-ai-agent/glint
that referenced
this pull request
Jul 28, 2026
Adds two global registries to @glint/template: - GlintCustomElementTagNameMap: tag name -> element instance type (mirroring HTMLElementTagNameMap), giving registered custom elements a real element type for modifiers, ...attributes, and hover info. - GlintCustomElementAttributesMap: tag name -> accepted attributes, checked strictly when registered. Plain elements now resolve their attributes from the tag name they were written with (via a new applyTagAttributes DSL function and name/attributes members on the emitElement result) rather than from the element instance type, so attributes can be registered for a tag without registering the element type. Components keep resolving attributes from their signature's Element type, now with a reverse lookup into the custom element registry and a graceful fallback for unregistered Element subclasses (previously the lookup produced 'never', rejecting every attribute). Resolves typed-ember#808 Supersedes typed-ember#1016 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #808