Add run_nix_shell #664
Open
Add run_nix_shell #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malt3
reviewed
Dec 2, 2025
Contributor
malt3
left a comment
malt3
left a comment
There was a problem hiding this comment.
Looks pretty good to me. I think this would be a little nicer using an output_list.
core/nixpkgs.bzl
Outdated
| run_nix_shell = rule( | ||
| implementation = _run_nix_shell_impl, | ||
| attrs = { | ||
| "output": attr.string( |
Contributor
There was a problem hiding this comment.
Suggested change
| "output": attr.string( | |
| "outputs": attr.output_list( |
I think an output list would give us a bit more flexibility. This way, users can define multiple outputs for a single action. This also avoids the need to ctx.actions.declare_file. Instead, the file is available through ctx.outputs.outputs.
Member
Author
There was a problem hiding this comment.
Makes sense, thanks @malt3 , I just updated the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615