Split v2 and v3 scripts #94
Conversation
| IO () | ||
| writePlutusScript filename (CompiledCodeLang compiledCode) = do | ||
| let serialisedScript = serialiseCompiledCode compiledCode | ||
| let serialisedScript = V2.serialiseCompiledCode compiledCode |
There was a problem hiding this comment.
serialiseCompiledCode is the same on V3, V2, and V1.
There was a problem hiding this comment.
Yep, I know, it was a part of the investigation why V3 doesn't work.
| FilePath -> | ||
| CompiledCode a -> | ||
| IO () | ||
| writePlutusScriptV3 filename compiledCode = do |
There was a problem hiding this comment.
This is the same as writePlutusScript.
CompiledCodeLang lang a is a custom type I introduced to encode lang as a proxy.
writePlutusScript should work (hopefully - I'll verify this.) for all the options.
| @@ -1,4 +1,6 @@ | |||
| module Onchain.Escrow where | |||
| {-# OPTIONS_GHC -fplugin-opt PlutusTx.Plugin:target-version=1.0.0 #-} | |||
There was a problem hiding this comment.
What does this plugin affect?
My (uneducated) guess is that it only affects the logic where compile is used.
There was a problem hiding this comment.
Yeah, it changes the version of the generated plutus code in the module
| import PlutusLedgerApi.V3 qualified as V3 | ||
| import PlutusTx qualified | ||
| import PlutusTx.Builtins (unsafeDataAsI) | ||
| import PlutusTx.Builtins.Internal qualified as BI ( |
There was a problem hiding this comment.
We should try to avoid using Internal stuff.
I assume you've used this for testing/hacking.
| @@ -1,3 +1,5 @@ | |||
| {-# OPTIONS_GHC -fplugin-opt PlutusTx.Plugin:target-version=1.0.0 #-} | |||
There was a problem hiding this comment.
We can either use macros, or if it becomes too hairy, we can move this to V2/Compiled
| @@ -0,0 +1,8 @@ | |||
| { | |||
There was a problem hiding this comment.
You can send datum inline as well.
Using a file will, however, avoid the quirks of shell escaping.
Is it a good idea to generate the datum on demand using dev-local instead?
There was a problem hiding this comment.
I was just playing with different datums, can be removed
| makeAppEnv = do | ||
| let policyFilePath = env_LOCAL_CONFIG_DIR </> "policy.plutus" | ||
| validatorFilePath = env_LOCAL_CONFIG_DIR </> "validator.plutus" | ||
| validatorFilePath = env_LOCAL_CONFIG_DIR </> "validator-v3.plutus" |
There was a problem hiding this comment.
We should probably abstract this out properly.
Creating a PR for furthering the discussion.