fix(tooltip): coerce boolean title/content to string#42365
Closed
fix(tooltip): coerce boolean title/content to string#42365
Conversation
Data attributes parsed via Manipulator.normalizeData convert "true"/"false" to actual booleans, which then fail the (null|string|element|function) type check for popover/tooltip content. Mirror the existing number → string coercion in _configAfterMerge so that data-bs-content="true" renders the literal string "true". Closes twbs#41925
Member
|
Closing as duplicate of #42155. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #41925.
data-bs-content=\"true\"(or\"false\") on a popover/tooltip throws:This is because
Manipulator.normalizeDataconverts the strings\"true\"/\"false\"to actual booleans before the config type check runs._configAfterMergealready coerces numerictitle/contentback to strings — this PR extends that same pattern to booleans, so the literal strings\"true\"/\"false\"render as expected.Test plan