Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prettier-plugin-astroinsite/.prettierrc.jsonsodocs-prettier-checkactually checks.astrofiles, then ran--writeacross the site to catch drift it had been silently missing.<Stylesheet />/<ScssProd.default />inHead.astroin a JSX fragment so the newly-enabled Astro Prettier plugin parses it cleanly.site/src/assets/snippets.js(nothing imported it) and removed its entry fromeslint.config.js.@bootstrappath alias (tsconfig + Viteresolve.alias) pointing atdist/js/bootstrap.bundle.js, and replaced every../../../../dist/js/bootstrap.bundle.jsimport with it — 7 files:site/src/assets/partials/snippets.js,site/src/assets/partials/toc.js,site/src/libs/clipboard.ts,site/src/components/shortcodes/Code.astro,ButtonPlayground.astro,MenuPlacementPlayground.astro,NavbarPlacementPlayground.astro. Keeps every docs script importing from a single module instance (no duplicated component registries).application.js,search.js,partials/sidebar.js,partials/sticky.js,partials/toc.js,partials/snippets.js, andstackblitz.js.@assets/*tsconfig path alias.layoutprop fromStylesheet.astro(and the two callers inHead.astro/ExamplesLayout.astro).is:inlinecolor-modes.jsreferences inHead.astroandExamplesLayout.astrodocumenting why it stays outside the Vite pipeline (needs to render-block pre-paint to avoid a flash of the wrong theme).DocsScripts.astrointoScripts.astrobut Astro bundles<script>per component file, so inlining it under a{layout === 'docs' && ...}guard either breaks bundling or always-loads the StackBlitz SDK — kept it split and added a comment explaining why.SidebarGroup/SidebarItem/SidebarSubItemtypes inferred from the Zod sidebar schema inlibs/data.ts, and swapped theanycasts inDocsSidebar.astro+DocsLayout.astrofor the real types. Added a null guard onitem.titleinDocsSidebar.astrosince the schema field is optional.stripMarkdown/processMarkdownToHtmlinlibs/utils.tsonto a singleremark+remark-htmlpipeline, dropping the directmdast-util-from-markdown/mdast-util-to-stringimports in the process.@oddbird/css-anchor-positioningpolyfill<script>fromHead.astroand uninstalled the devDep — nothing inv6-devactually declaresanchor-name(that work lives on the unmergedfeature/popover-api-anchor-positioningbranch), so the polyfill was a no-op on every page. Easy to add back when that branch lands.