Conversation
Elvira2227
added
IFC
|
Maybe it could make sense to take the list of differences between IFC4x3_RC4 and IFC4x3 and make an internal list that just contains the information about the part that is relevant for us. That would help us to then also put check marks for the ones that we already resolved. |
jschlenger
left a comment
jschlenger
left a comment
There was a problem hiding this comment.
Looks good so far. Does it already compile?
I really think a table with changes relevant to OIP makes sense here.
Then we could, e.g. already tick of that the name changes of sine and cosine was taken care of.
|
In the last commit 7076b77 I listed relevant changes for OIP. |
jschlenger
left a comment
jschlenger
left a comment
There was a problem hiding this comment.
Good start.
There are a couple of entities missing that could also be relevant for us.
pjanck
left a comment
pjanck
left a comment
There was a problem hiding this comment.
Seems fine, the changes are in all correct places. Does it compile though? In both 4x3 and 4x3rc4?
| bool fixedAxisVertical = sectionedSolidHorizontal->FixedAxisVertical; | ||
|
|
||
| #else | ||
| bool fixedAxisVertical = true;//please rewrite it!! wrong implementation |
3 participants
This pull request contains final schema for IFC4X3.
Please find differences between _RC4 here.
Several changes correspond to the
CurveConverter. Here I added someif definestatements.We need also to update implementation for the
IfcSectionedSolidHorizontal#570.