perf: reduce tooltip hover over-rendering in 3d viewer#717
Open
gavin-openops wants to merge 1 commit intotscircuit:mainfrom
Open
perf: reduce tooltip hover over-rendering in 3d viewer#717gavin-openops wants to merge 1 commit intotscircuit:mainfrom
gavin-openops wants to merge 1 commit intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces hover-triggered over-rendering that causes lag while moving across dense 3D scenes.
What changed
onHoverupdates when the hovered object stays the same.Why
Issue #94 reports major slowdown while hovering tooltips. The previous behavior pushed state updates on every mousemove + raycast tick for the same object, which can trigger excessive React rerenders.
Validation
bun run format:check src/react-three/HoverContext.tsxbun run buildbun run test:node-bundle/claim #94