Fix translucent rendering updates for STEP-backed glTF models#690
Draft
Fix translucent rendering updates for STEP-backed glTF models#690
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
gltfUrlso the model is not reloaded when translucency changes.modelorisTranslucentchanges, and applytransparent,opacity,depthWrite, andneedsUpdateto each material.isTranslucentstate.Testing
bunx tsc --noEmitcompleted successfully and reported no type errors.bun test testsexecuted 12 tests across 7 files with 10 passing and 2 failing tests intests/preprocess-circuit-json.test.ts, which are unrelated to the glTF translucency changes.bun run formatran and formatted files successfully.Codex Task