perf: optimize hover handling to prevent unnecessary re-renders#677
Open
agent-steven wants to merge 1 commit intotscircuit:mainfrom
Open
perf: optimize hover handling to prevent unnecessary re-renders#677agent-steven wants to merge 1 commit intotscircuit:mainfrom
agent-steven wants to merge 1 commit intotscircuit:mainfrom
Conversation
Add throttling and position-based filtering to hover events: 1. Throttle mousemove events to ~60fps (16ms) 2. Skip onHover calls when hovering same object if position hasn't changed beyond threshold (0.1 units) 3. Clean up position tracking on unhover This reduces CPU usage and prevents re-render storms when moving mouse over 3D components. Fixes tscircuit#94
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #94
Summary
Fixes the major slowdown when hovering over components in the 3D viewer.
Problem
As noted by @DrSensor, the hover system was triggering excessive re-renders because:
onHoverwas called on every mouse move eventSolution
Optimized
HoverContext.tsxwith:onHoverwhen:Changes
src/react-three/HoverContext.tsx: Added throttling and position-based filteringTesting
The fix reduces unnecessary
onHovercalls from hundreds per second to only when meaningful changes occur, significantly improving frame rate and reducing CPU usage.