Test new prompt #32
Test new prompt #32
Conversation
|
/gemini-review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| def create_prompt(file: PatchedFile, hunk: Hunk, pr_details: PRDetails) -> str: | ||
| """Creates the prompt for the Gemini model.""" | ||
| return f"""Your task is reviewing pull requests. Instructions: | ||
| - Provide the response in following JSON format: {{"reviews": [{{"lineNumber": <line_number>, "reviewComment": "<review comment>"}}]}} |
There was a problem hiding this comment.
The instruction "Skip style or documentation suggestions" contradicts the purpose of code review, which includes maintaining code quality and readability. Consider removing this instruction.
|
/gemini-review |
Dockerfile
Outdated
|
|
||
| # testing the security detection | ||
| RUN echo Password is `cat /cfg/password.txt` | ||
|
|
There was a problem hiding this comment.
Storing sensitive information like passwords directly in the Dockerfile is a security risk. Use environment variables or secrets management tools instead.
| def create_prompt(file: PatchedFile, hunk: Hunk, pr_details: PRDetails) -> str: | ||
| """Creates the prompt for the Gemini model.""" | ||
| return f"""Your task is reviewing pull requests. Instructions: | ||
| - Provide the response in following JSON format: {{"reviews": [{{"lineNumber": <line_number>, "reviewComment": "<review comment>"}}]}} |
There was a problem hiding this comment.
The prompt should explicitly mention that the review response should ONLY contain code suggestions and comments related to the provided code diff. It should also specify that the response must adhere to the provided JSON format even if there are no suggestions (i.e., return an empty reviews array).
| return f"""Your task is reviewing pull requests. Instructions: | ||
| - Provide the response in following JSON format: {{"reviews": [{{"lineNumber": <line_number>, "reviewComment": "<review comment>"}}]}} | ||
| - Do not give positive comments or compliments. | ||
| - Provide comments and suggestions ONLY if there is something to improve, otherwise "reviews" should be an empty array. |
There was a problem hiding this comment.
Instructions should be more precise. For example, instead of "Focus on bugs, security issues, and performance problems", it should say something like "Focus on identifying and suggesting fixes for bugs, potential security issues, and performance problems within the provided code diff."
| - Do not give positive comments or compliments. | ||
| - Provide comments and suggestions ONLY if there is something to improve, otherwise "reviews" should be an empty array. | ||
| - Write the comment in GitHub Markdown format. | ||
| - Use the given description only for the overall context and only comment the code. |
There was a problem hiding this comment.
The variable adjusted_line_number looks like it should be zero-indexed based on hunk.source_start and the subsequent usage in the position field of the comment. Consider clarifying this with a comment or renaming to zero_indexed_line_number for better readability. Also, it might be worth adding a check to ensure adjusted_line_number does not exceed hunk.source_start + hunk.source_length.
No description provided.