Merge pull request #32 from truongnh1992/improve-prompt

Test new prompt

Author: truongnh1992

Demo.png

@@ -33,7 +33,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Repo
-        uses: actions/checkout@v4
+        uses: actions/checkout@v3
 
       - name: Run Gemini AI Code Reviewer
         uses: truongnh1992/gemini-ai-code-reviewer@latest
@@ -43,8 +43,9 @@ jobs:
           INPUT_EXCLUDE: "*.md,*.txt,package-lock.json,*.yml,*.yaml" # Optional: exclude patterns separated by commas
 ```
 
-4. Commit codes to your repository, and `Gemini AI Code Reviewer` will start working on your pull requests.
-   
+4. Commit codes to your repository, and working on your pull requests.
+5. When you're ready to review the PR, you can trigger the workflow by commenting `/gemini-review` in the PR.
+
 ## How It Works
 
 This GitHub Action uses the Gemini AI API to provide code review feedback. It works by:

README.md

@@ -135,11 +135,10 @@ def create_prompt(file: PatchedFile, hunk: Hunk, pr_details: PRDetails) -> str:
     """Creates the prompt for the Gemini model."""
     return f"""Your task is reviewing pull requests. Instructions:
     - Provide the response in following JSON format:  {{"reviews": [{{"lineNumber":  <line_number>, "reviewComment": "<review comment>"}}]}}
-    - Do not give positive comments or compliments.
     - Provide comments and suggestions ONLY if there is something to improve, otherwise "reviews" should be an empty array.
-    - Write the comment in GitHub Markdown format.
-    - Use the given description only for the overall context and only comment the code.
-    - IMPORTANT: NEVER suggest adding comments to the code.
+    - Use GitHub Markdown in comments
+    - Focus on bugs, security issues, and performance problems
+    - IMPORTANT: NEVER suggest adding comments to the code
 
 Review the following code diff in the file "{file.path}" and take the pull request title and description into account when writing the response.
   
@@ -216,15 +215,14 @@ def create_comment(file: FileInfo, hunk: Hunk, ai_responses: List[Dict[str, str]
             line_number = int(ai_response["lineNumber"])
             print(f"Original AI suggested line: {line_number}")
 
-            # Ensure the line number is within the hunk's range
-            if line_number < 1 or line_number > hunk.source_length:
-                print(f"Warning: Line number {line_number} is outside hunk range")
-                continue
+            # Adjust line number to be relative to the hunk's starting position
+            adjusted_line_number = hunk.source_start + line_number - 1
+            print(f"Adjusted line number: {adjusted_line_number}")
 
             comment = {
                 "body": ai_response["reviewComment"],
                 "path": file.path,
-                "position": line_number
+                "position": adjusted_line_number
             }
             print(f"Created comment: {json.dumps(comment, indent=2)}")
             comments.append(comment)